Innovenergy
/
Innovenergy_trunk
3
1
Fork 1
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

Assert Crc check messages

This commit is contained in:
atef 2025-08-04 10:40:55 +02:00
parent e3a4aace09
commit 661201617c
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
csharp/Lib/Protocols/Modbus/Clients/ModbusRtuClient.cs
View File

@ -88,6 +88,9 @@ public class ModbusRtuClient : ModbusClient
// TX // TX
cmd.Data.Concat(crc).ToList().Apply(Channel.Write); cmd.Data.Concat(crc).ToList().Apply(Channel.Write);
//var fullRequest = cmd.Data.Concat(crc).ToArray();
//Console.WriteLine("📤 C# Modbus TX: " + BitConverter.ToString(fullRequest));
// RX // RX
var response = Channel var response = Channel
@ -127,11 +130,21 @@ public class ModbusRtuClient : ModbusClient
public static ArraySegment<Byte> AssertCrc(ArraySegment<Byte> data) public static ArraySegment<Byte> AssertCrc(ArraySegment<Byte> data)
{ {
if (data.Count < 3)
throw new ArgumentException("Data too short to contain CRC", nameof(data));
var expectedCrc = data.SkipLast(CrcSize).Apply(CalcCrc); var expectedCrc = data.SkipLast(CrcSize).Apply(CalcCrc);
var actualCrc = data.TakeLast(CrcSize); var actualCrc = data.TakeLast(CrcSize);
if (!actualCrc.SequenceEqual(expectedCrc)) if (!actualCrc.SequenceEqual(expectedCrc))
{
Console.WriteLine($"❌ CRC mismatch!");
Console.WriteLine($"Expected CRC: {BitConverter.ToString(expectedCrc.ToArray())}");
Console.WriteLine($"Actual CRC: {BitConverter.ToString(actualCrc.ToArray())}");
Console.WriteLine($"Raw data: {BitConverter.ToString(data.ToArray())}");
throw new CrcException(expectedCrc, actualCrc); throw new CrcException(expectedCrc, actualCrc);
}
return data; return data;
} }