Innovenergy
/
Innovenergy_trunk
3
1
Fork 1
Code Issues 1 Pull Requests Packages Projects Releases Wiki Activity

avoid adding folder to itself, children and parent

This commit is contained in:
Yinyin Liu 2026-02-26 13:13:38 +01:00
parent 80639e9169
commit abedc6c203
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
csharp/App/Backend/DataTypes/Methods/Session.cs
View File

@ -41,9 +41,12 @@ public static class SessionMethods
var user = session?.User;
var folder = Db.GetFolderById(folderId);
var parent = Db.GetFolderById(parentId);
return user is not null
&& folder is not null
&& parent is not null
&& folderId != parentId // can't move into itself
&& !IsFolderAncestorOf(folderId, parentId) // can't move into a descendant
&& user.UserType==2
&& user.HasAccessTo(folder)
&& user.HasAccessTo(parent)
@ -51,6 +54,19 @@ public static class SessionMethods
.Do(() => folder.ParentId = parentId)
.Apply(Db.Update);
}
// Walks up the folder tree from candidateDescendantId to check if ancestorId is an ancestor.
// Prevents circular references when moving a folder into one of its own descendants.
private static Boolean IsFolderAncestorOf(Int64 ancestorId, Int64 candidateDescendantId)
{
var current = Db.GetFolderById(candidateDescendantId);
while (current is not null && current.ParentId != 0)
{
if (current.ParentId == ancestorId) return true;
current = Db.GetFolderById(current.ParentId);
}
return false;
}
public static Boolean MoveInstallation(this Session? session, Int64 installationId, Int64 parentId)
{